Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding --name-only option for dolt diff #7802

Merged
merged 8 commits into from
Apr 30, 2024
Merged

adding --name-only option for dolt diff #7802

merged 8 commits into from
Apr 30, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Apr 30, 2024 •
edited
Loading

This PR adds support for --name-only option for dolt diff, which just prints the tables that have changed between the two commits. This mirrors git diff --name-only.

fixes: #7797

@timsehn
Copy link
Contributor

timsehn commented Apr 30, 2024

Should this be --name-only to match Git? Seems better but maybe a vote in #dolt-internal?

@fulghum
Copy link
Contributor

fulghum commented Apr 30, 2024

Should this be --name-only to match Git? Seems better but maybe a vote in #dolt-internal?

Good question; I was wondering the same. My vote is to match git here, too.

fulghum
fulghum approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. My only comment is that it seems worth matching Git with --name-only here instead of changing it to --table-only. Let me know if you think there's a compelling reason not to match Git though.

@jycor jycor changed the title adding --table-only option for dolt diff adding --name-only option for dolt diff Apr 30, 2024
@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4a76f29 ok 5937457
version total_tests
4a76f29 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
348fdf5 ok 5937457
version total_tests
348fdf5 5937457
correctness_percentage
100.0

@jycor jycor merged commit 4249386 into main Apr 30, 2024
20 of 21 checks passed
@jycor jycor deleted the james/name branch April 30, 2024 22:48
@BrewTestBot BrewTestBot mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dolt diff ... that only shows the tables changed in a simpler format
4 participants
@jycor @timsehn @fulghum @coffeegoddd